block_disk_not_default_options: creates new test case #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
2 times, most recently
from
66f362b to
8442610
Compare
|
Tests results |
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
from
8442610 to
9817d33
Compare
|
@qingwangrh could you review this PR? Thanks ! |
qingwangrh
reviewed
Nov 18, 2024
| remove_image_stg0 = yes | ||
| force_create_image_stg0 = yes | ||
| dd_cmd = "dd if=/dev/urandom of=test.txt bs=1M count=10" | ||
| virtio_blk: |
There was a problem hiding this comment.
The file is the non-default option comment test, it will evolve to cover other option test. so I suggest considering current test as one variant: example - with_packed_and_ppv
qingwangrh
reviewed
Nov 18, 2024
| image_size_stg0 = 40G | ||
| remove_image_stg0 = yes | ||
| force_create_image_stg0 = yes | ||
| dd_cmd = "dd if=/dev/urandom of=test.txt bs=1M count=10" |
There was a problem hiding this comment.
The dd cmd should affect the disk with specified option.
qingwangrh
reviewed
Nov 18, 2024
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
2 times, most recently
from
2166cd8 to
c955535
Compare
qingwangrh
reviewed
Nov 19, 2024
| session.cmd(params.get("dd_cmd")) | ||
|
|
||
| possible_types = {"virtio-blk-device", "virtio-scsi-device"} | ||
| verify_non_default_options("packed", possible_types) |
There was a problem hiding this comment.
it can comes from cfg instead of hard code
qtree_check={k1:v1}
There was a problem hiding this comment.
qtree verification implemented in cfg side, so the user can configure it to verify any option of a desired device
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
from
c955535 to
1400868
Compare
qingwangrh
reviewed
Nov 20, 2024
| dd_cmd = "dd if=/dev/urandom of=test.txt bs=1M count=10" | ||
| variants: | ||
| - with_packed_and_ppv: | ||
| qtree_check = '{"packed" : ["virtio-blk-device", "virtio-scsi-device"], "page-per-vq" : ["virtio-blk-pci", "virtio-scsi-pci"]}' |
There was a problem hiding this comment.
- it can be evolved to support different image ,like as
qtree_check_images=" stg0 stg1...."
qtree_check_image_stg0='{"packed" : ["virtio-blk-device", "virtio-scsi-device"], "page-per-vq" : ["virtio-... - where is the value definition ?example, I want to check the key1 value is "ABC"?
qingwangrh
reviewed
Nov 21, 2024
| if qtree_check: | ||
| for key in qtree_check: | ||
| verify_non_default_options(key, qtree_check[key]) | ||
| else: |
There was a problem hiding this comment.
The qtree_check is not mandatory, so I suggest changing it to warn message, otherwise, the case will be looked as failed case.
There was a problem hiding this comment.
@qingwangrh yeah I thought about that and changed it yesterday :) I will push the new changes asap
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
2 times, most recently
from
564547b to
dea631d
Compare
|
@qingwangrh now the qtree check should be fully implemented, still working on the dd cmd improvement |
|
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
from
dea631d to
cd1213e
Compare
|
@mcasquer Please don't forget to add -S when pushing the patch. (I.E. commit signature) |
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
from
cd1213e to
5496417
Compare
Sorry for that, it's been a one-time oversight 😅 |
|
Once the dependent patch #4219 gets merged, CI should be green after rebase |
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
2 times, most recently
from
c6db2da to
e194141
Compare
|
After applying the dependent patch: Win10 guest with virtio_scsi Win2025 guest with virtio_blk |
|
This is a kindly reminder, @qingwangrh please could you review again this PR? Thanks ! |
|
Added @XueqiangWei |
Creates a new test case that boots up a VM with a disk configured with non-common options such as packed or page-per-vq. Unplug the disk and hotplugs it again. Signed-off-by: Mario Casquero <[email protected]>
mcasquer
force-pushed
the
3007_booting_hotplugging_disk_non_default_options
branch
from
e194141 to
bd82563
Compare
|
With last update on the provider: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4219
block_disk_not_default_options: creates new test case
Creates a new test case that boots up a VM with a disk
configured with non-common options such as packed or
page-per-vq. Unplug the disk and hotplugs it again.
Signed-off-by: Mario Casquero [email protected]
ID: 3007