Virtiofs: Reboot vm during virtiofs is working #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcheng-redhat
force-pushed
the
virtiofs_reboot
branch
from
4e21952 to
43d8d17
Compare
|
Hi @hellohellenmao Please help review this patch. Tested with Win10 and rhel guests, both passed. |
fbq815
approved these changes
Dec 11, 2024
xiagao
reviewed
Dec 16, 2024
| "After reboot: %s\n", | ||
| (vfsd_num_bf, vfsd_num_af), | ||
| for reboot_cmd in ["shell", "system_reset"]: | ||
| error_context.context( |
There was a problem hiding this comment.
As there are two reboot operations, for the second reboot please re-mount the viofs file system.
There was a problem hiding this comment.
Thank you for review. Updated. @xiagao
Signed-off-by: qcheng-redhat <[email protected]>
qcheng-redhat
force-pushed
the
virtiofs_reboot
branch
from
43d8d17 to
291e9fa
Compare
|
It looks good to me. @qcheng-redhat Could you update the latest results with the latest codes? |
|
Tested with RHEL 9， Win10 and Win11 guests. RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reboot vm by system_reset during virtiofs is working
ID: 3129