block_hotplug_with_max_map_count: creates new test case #4225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@qingwangrh please could you review this PR? Thanks! |
|
This is a kindly reminder, @qingwangrh please could you review this PR? Thanks ! |
qingwangrh
reviewed
Dec 10, 2024
| maxmem_mem = 80G | ||
| mem = 4096 | ||
| pcie_extra_root_port = 30 | ||
| images += " stg1 stg2 stg3 stg4 stg5 stg6 stg7 stg8 stg9 stg10 stg11 stg12 stg13 stg14 stg15 stg16 stg17" |
There was a problem hiding this comment.
suggest using extra_image_number to define the additional images, you already support dynamic create images. it is more flexible.
| :param env: Dictionary with test environment | ||
| """ | ||
|
|
||
| process.system("sysctl vm.max_map_count=3072", shell=True) |
There was a problem hiding this comment.
could you please add reading value and store, then write it back after testing in final block?
| timeout = params.get_numeric("login_timeout", 240) | ||
| img_list = params.get("images").split()[3:] | ||
|
|
||
| for img in img_list: |
There was a problem hiding this comment.
for idx in range(extra_image_number):
img="img"+idx
....
you may define the var name you feel good.
Creates new test case that boots up a VM with a small max_map_count, then hotplugs 15 disks and checks the VM status. Signed-off-by: mcasquer <[email protected]>
mcasquer
force-pushed
the
3130_max_map_count_disk_hotplug
branch
from
b95de9d to
82351a8
Compare
|
|
@qingwangrh please could you review again this PR? Thanks ! |
|
@zhencliu @YongxueHong could you also review this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block_hotplug_with_max_map_count: creates new test case
Creates new test case that boots up a VM with a small max_map_count,
then hotplugs 15 disks and checks the VM status.
Signed-off-by: mcasquer [email protected]
ID: 3130