-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win_virtio_driver_install_by_installer: support viomem test #4234
base: master
Are you sure you want to change the base?
Conversation
b11a025
to
731e176
Compare
@vivianQizhu A quick question is How do think we won't consider the rpm version for viomem, so the cfg will be more easier to organize for now and in the future if new feature coming ? Currently we organize the viomem part in the cfg file considering the rpm version, the question is that as xiaogao comment "in the future when there are more drivers support, I think it's hard to extend the variants." Both are okay for me, so just to confirm we all agree the same method before I take action to modify it again. |
I confirmed with @menli820 about some failure test results offline discussion, and the root cause is a known product bug. @menli820 will post the new patch to avoid the effect of the product bug. And then, I will review it again. I have my Kar cmdline here for you to refer to.
|
731e176
to
6eab70e
Compare
6eab70e
to
ebd3021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kar encountered a product bug unrelated to this patch(the installer code related has passed) and confirmed with @menli820, so LGTM.
ebd3021
to
2cabd5b
Compare
# mainly to cover win10.i386 test without viomem | ||
boot_with_viomem = no | ||
Host_RHEL.m7, Host_RHEL.m8, Host_RHEL.m9.u0, Host_RHEL.m9.u1, Host_RHEL.m9.u2, Host_RHEL.m9.u3, Host_RHEL.m9.u4: | ||
boot_with_viomem = no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was defined in above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually in my understanding it is not a conflict,the first ‘boot_with_viomem = no’ is for i386.
the second if for both x86_64 and i386.
Add supoport to test viomem related from the installer. Signed-off-by: menli <[email protected]>
2cabd5b
to
7037ecf
Compare
Add supoport to test viomem related from
the installer.
ID: 3171, 3191, 3192, 3193, 3194