virtio_fs_share_data_hugepage: correct cache argument #4241
Conversation
|
@hellohellenmao , could you help review this one ? Thank you. |
|
(2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.auto.q35: PASS (70.81 s) |
|
LGTM |
|
@YongxueHong Could you please help to take a review here? THanks |
|
Hi @MiriamDeng @fbq815 @xiagao |
| - none: | ||
| fs_binary_extra_options += ",cache=none" | ||
| fs_binary_extra_options += " --cache=never" |
There was a problem hiding this comment.
Hi @zhaojunyao7
Do we consider updating the variant name to never?
I prefer to update it since it is more earlier to understand the case purpose.
Pls let me know your opinions. Thanks.
zhaojunyao7
force-pushed
the
KVMAUTOMA-2917
branch
2 times, most recently
from
1a525be to
d22f731
Compare
|
@YongxueHong Thanks for you advice, updated the variant name to never. |
|
It looks good to me. ACK. |
|
@YongxueHong , could you merge this if no other comment? |
Hi @zhaojunyao7 |
|
@maxujun could you please help to check it on ppc side ? |
zhaojunyao7
force-pushed
the
KVMAUTOMA-2917
branch
3 times, most recently
from
580edc2 to
94999eb
Compare
change cache argument of virtiofsd from',cache=' to ' --cache=' and update the cache mode 'none' to 'never' to match with the latest production behavior. Signed-off-by: Junyao Zhao <[email protected]>
zhaojunyao7
force-pushed
the
KVMAUTOMA-2917
branch
from
94999eb to
e47c35e
Compare
|
JOB LOG : /root/avocado/job-results/job-2025-02-06T21.42-865daab/job.log |
|
@maxujun , I have updated the code to support RHEL 8 and versions later than RHEL 8. Could you help confirm if this works for your case? |
|
For PPC RHEL8.10 qemu，it's not availible. The usage is "-o cache=<auto, always, none>".
(1/6) Host_RHEL.m8.u10.product_rhel.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.ppc64le.io-github-autotest-qemu.virtio_fs_share_data_hugepage.basic_test.with_cache.auto: STARTED LGTM. |
|
@YongxueHong Could you please help to take a review again? Please help to merge if it's okay for you. |
| - never: | ||
| !Host_RHEL.m8: | ||
| fs_binary_extra_options += " --cache=never" | ||
| Host_RHEL.m8: | ||
| fs_binary_extra_options += " -o cache=none" |
There was a problem hiding this comment.
Hi @zhaojunyao7 @hellohellenmao @xiagao
Does it make sense that we set the fs_binary_extra_options += " -o cache=none" for RHEL 8 host mandatory?
And from the @maxujun 's comment, just there is no such usage -o cache=<auto, always, none> on PPC, so do we need to extend this limitation to all the platforms? or this usage does work with other platforms neither.
Thanks.
There was a problem hiding this comment.
Yes, for all the platform.
| !Host_RHEL.m8: | ||
| fs_binary_extra_options += " --cache=auto" | ||
| Host_RHEL.m8: | ||
| fs_binary_extra_options += " -o cache=auto" |
There was a problem hiding this comment.
| !Host_RHEL.m8: | |
| fs_binary_extra_options += " --cache=auto" | |
| Host_RHEL.m8: | |
| fs_binary_extra_options += " -o cache=auto" | |
| fs_binary_extra_options += " --cache=auto" | |
| Host_RHEL.m8: | |
| fs_binary_extra_options += " -o cache=auto" |
Hi @xiagao @maxujun @fbq815
Could you help to review it? Thanks a lot
change cache argument of virtiofsd from',cache=' to ' --cache=' and update the cache mode 'none' to 'never' to match with the latest production behavior.
ID:2917
Signed-off-by: Junyao Zhao [email protected]