fix(learning_based_vehicle_model): fix clang-diagnostic-delete-abstract-non-virtual-dtor

[yhisaki]

Description

This is a fix based on clang-tidy clang-diagnostic-delete-abstract-non-virtual-dtor error.

Command: clang-tidy-14 -p build/learning_based_vehicle_model --header-filter=/home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/simulator/learning_based_vehicle_model/.* --config-file=.clang-tidy-ci /home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/simulator/learning_based_vehicle_model/src/interconnected_model.cpp
2 errors generated.
Error while processing /home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/simulator/learning_based_vehicle_model/src/interconnected_model.cpp.
Found compiler error(s).

/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:95:2: error: delete called on 'SubModelInterface' that is abstract but has non-virtual destructor [clang-diagnostic-delete-abstract-non-virtual-dtor]
        delete __ptr;
        ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:396:4: note: in instantiation of member function 'std::default_delete<SubModelInterface>::operator()' requested here
          get_deleter()(std::move(__ptr));
          ^
/home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/simulator/learning_based_vehicle_model/src/interconnected_model.cpp:79:23: note: in instantiation of member function 'std::unique_ptr<SubModelInterface>::~unique_ptr' requested here
  submodels.push_back(std::unique_ptr<SimplePyModel>(new_model));
                      ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:95:2: error: delete called on non-final 'SimplePyModel' that has virtual functions but non-virtual destructor [clang-diagnostic-delete-non-abstract-non-virtual-dtor]
        delete __ptr;
        ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/unique_ptr.h:396:4: note: in instantiation of member function 'std::default_delete<SimplePyModel>::operator()' requested here
          get_deleter()(std::move(__ptr));
          ^
/home/hisaki/workspace/clang-tidy-ci/autoware/src/universe/autoware.universe/simulator/learning_based_vehicle_model/src/interconnected_model.cpp:79:23: note: in instantiation of member function 'std::unique_ptr<SimplePyModel>::~unique_ptr' requested here
  submodels.push_back(std::unique_ptr<SimplePyModel>(new_model));
                      ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 29.47%. Comparing base (4b11912) to head (b225870).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...g_based_vehicle_model/src/interconnected_model.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9506      +/-   ##
==========================================
- Coverage   29.48%   29.47%   -0.01%     
==========================================
  Files        1444     1446       +2     
  Lines      108268   108259       -9     
  Branches    42193    42168      -25     
==========================================
- Hits        31918    31909       -9     
- Misses      73268    73271       +3     
+ Partials     3082     3079       -3     

Flag	Coverage Δ		*Carryforward flag
differential	27.21% <0.00%> (?)
total	29.47% <ø> (-0.01%)	⬇️	Carriedforward from 4b11912

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.