feat(autoware_crosswalk_traffic_light_estimator): overwrite invalid detection result #9667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MasatoSaeki <[email protected]>
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
MasatoSaeki
requested review from
satoshi-ota,
miursh and
tzhong518
as code owners
MasatoSaeki
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9667 +/- ##
==========================================
+ Coverage 28.77% 29.84% +1.07%
==========================================
Files 1456 1446 -10
Lines 109101 107360 -1741
Branches 42498 41889 -609
==========================================
+ Hits 31394 32046 +652
+ Misses 74631 71919 -2712
- Partials 3076 3395 +319
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tzhong518
approved these changes
Dec 27, 2024
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 6, 2025
…etection result (autowarefoundation#9667) * add code in order to check invalid detection Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 6, 2025
…etection result (autowarefoundation#9667) * add code in order to check invalid detection Signed-off-by: MasatoSaeki <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables to overwrite invalid detection result made by ML.
Concretely, overwrite if below condition:
undetection -> color: unknown, shape: circle, confidence=0.0
backlight -> color: unknown, shape: unknown, confidence=0.0
occlusion -> color: unknown, shape: unknown, confidence=0.0
Related links
Parent Issue:
How was this PR tested?
see this page
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.