Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): remove unused function mask() #9751

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Dec 24, 2024

Description

Fixed cppcheck warning

sensing/autoware_pointcloud_preprocessor/src/downsample_filter/robin_hood.h:2192:0: style: The function 'mask' is never used. [unusedFunction]
  ROBIN_HOOD(NODISCARD) size_t mask() const noexcept

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc self-assigned this Dec 24, 2024
@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test labels Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.79%. Comparing base (ca3afdd) to head (0492db5).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9751      +/-   ##
==========================================
+ Coverage   29.73%   29.79%   +0.05%     
==========================================
  Files        1449     1445       -4     
  Lines      108888   108569     -319     
  Branches    42747    42636     -111     
==========================================
- Hits        32381    32351      -30     
+ Misses      73321    73036     -285     
+ Partials     3186     3182       -4     
Flag Coverage Δ *Carryforward flag
differential 23.93% <ø> (?)
total 29.80% <ø> (+0.06%) ⬆️ Carriedforward from 4045fb3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veqcc veqcc merged commit 57f38b7 into autowarefoundation:main Dec 24, 2024
42 of 49 checks passed
@veqcc veqcc deleted the fix/unusedFunction branch December 24, 2024 04:34
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Dec 25, 2024
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants