-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change_module): add update paramter function for non defined paramters #9887
feat(lane_change_module): add update paramter function for non defined paramters #9887
Conversation
…delay lane change functionality Signed-off-by: Kyoichi Sugahara <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp
Outdated
Show resolved
Hide resolved
… acceleration sampling parameters Signed-off-by: Kyoichi Sugahara <[email protected]>
…on sampling number Signed-off-by: Kyoichi Sugahara <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9887 +/- ##
========================================
Coverage 29.47% 29.48%
========================================
Files 1444 1446 +2
Lines 108232 108722 +490
Branches 42168 42441 +273
========================================
+ Hits 31904 32056 +152
- Misses 73249 73575 +326
- Partials 3079 3091 +12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kyoichi Sugahara <[email protected]>
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp
Outdated
Show resolved
Hide resolved
planning/behavior_path_planner/autoware_behavior_path_lane_change_module/src/manager.cpp
Outdated
Show resolved
Hide resolved
…tion mapping Signed-off-by: Kyoichi Sugahara <[email protected]>
9c0e183
into
autowarefoundation:main
Description
In the original implementation, while some parameters could be updated through
ros2 param set
and affected the behavior, other parameters did not influence the behavior despite being updated.However, since both the output and
ros2 param dump
results showed the changes, developers might have believed they had modified parameters when in fact the changes weren't affecting the system. This could cause issues during parameter tuning. This is caused by the parameter server that publishes misleading messages.To address this, I've modified the implementation to ensure all parameters can affect the behavior through the updateParam function, making the runtime parameter updates consistent and effective.
I removed the intermediate variables since they appeared redundant, but I don't fully understand why they were implemented in the original code.
If these intermediate variables served a specific purpose (e.g., validation, safety checks, or compatibility), I will revert these changes.
How was this PR tested?
set paramter with following command with attached script
set_lane_change_param.zip
And got following output
output
run planning simulator and lane_change module executed.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.