Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): ensure path generation doesn't exceed time limit #9908

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Jan 14, 2025

Description

put a time limit on lane change candidate path sampling. If process exceeds time limit (parameterized), then will return current available valid paths.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added time_limit double 50.0 Time limit for lane change candidate path generation

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes missing coverage. Please review.

Project coverage is 29.51%. Comparing base (e96b361) to head (d857ca2).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...e_behavior_path_lane_change_module/src/manager.cpp 52.94% 7 Missing and 1 partial ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 16.66% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9908      +/-   ##
==========================================
+ Coverage   29.21%   29.51%   +0.29%     
==========================================
  Files        1425     1447      +22     
  Lines      107731   108724     +993     
  Branches    42178    42436     +258     
==========================================
+ Hits        31475    32088     +613     
- Misses      73159    73545     +386     
+ Partials     3097     3091       -6     
Flag Coverage Δ *Carryforward flag
differential 21.09% <43.47%> (?)
total 29.51% <ø> (+0.29%) ⬆️ Carriedforward from 70b6396

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: mohammad alqudah <[email protected]>
@mkquda mkquda merged commit e091937 into autowarefoundation:main Jan 16, 2025
33 of 34 checks passed
@mkquda mkquda deleted the RT1-9018-ensure-path-generation-doesnt-exceed-time-limit branch January 16, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants