This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
docs(autoware_common): added intersection_area doc #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
doc/intersection-area
branch
from
a80db97 to
996dd9a
Compare
soblin
changed the title
satoshi-ota
approved these changes
Jul 10, 2023
|
@mitsudome-r Can you review this PR as a code owner ? |
mitsudome-r
reviewed
Jul 19, 2023
| </relation> | ||
| ``` | ||
|
|
||
| The `intersection_area` should cover the entire drivable area inside the intersection as illustrated in the following figure with red solid line. |
There was a problem hiding this comment.
- Do you have any assumptions how we create the polygon for roundabouts where there is a traffic island in the center?
- Also do you allow multiple
intersection_areaassigned for a single lanelet? (I don't know if there is any usecase where we need multiple polygon, but just in case) - Will there be any restrictions about intersection area? (e.g. should the linked lanelet be completely within the area, or is it fine as long as "part" of the lanelet overlaps with the area)
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for intersection_area
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.