This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
feat!(lanelet2_extension): introduce API versioning along with format_version #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soblin
force-pushed
the
feat/format-version-api
branch
from
3a0d2bf to
a7c7ee9
Compare
7 tasks
soblin
force-pushed
the
feat/format-version-api
branch
from
a7c7ee9 to
e795025
Compare
soblin
requested review from
kosuke55,
Motsu-san,
mitsudome-r and
takayuki5168
as code owners
…_version Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/format-version-api
branch
from
e795025 to
4661d4f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return std::nullopt; | ||
| } | ||
| std::string minor = match[2].str(); | ||
| if (minor == "") { |
There was a problem hiding this comment.
the empty method should be used to check for emptiness instead of comparing to an empty object
Suggested change
| if (minor == "") { | |
| if (minor.empty()) { |
| } | ||
| std::string minor = match[2].str(); | ||
| if (minor == "") { | ||
| if (match[3].str() == "") { |
There was a problem hiding this comment.
the empty method should be used to check for emptiness instead of comparing to an empty object
Suggested change
| if (match[3].str() == "") { | |
| if (match[3].str().empty()) { |
| return std::nullopt; | ||
| } | ||
| std::string patch = match[3].str(); | ||
| if (patch == "") { |
There was a problem hiding this comment.
the empty method should be used to check for emptiness instead of comparing to an empty object
Suggested change
| if (patch == "") { | |
| if (patch.empty()) { |
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
soblin
force-pushed
the
feat/format-version-api
branch
from
1916683 to
b142e1c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/orgs/autowarefoundation/discussions/4740
Related links
Tests performed
Notes for reviewers
Interface changes
It is preferable for the user to define format_version for their map
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.