Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: change the config file directories from universe to autoware_launch #1201

Merged
merged 2 commits into from
Oct 31, 2024
Merged

chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: change the config file directories from universe to autoware_launch #1201

merged 2 commits into from
Oct 31, 2024

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Oct 30, 2024 •
edited
Loading

Description

To follow our standard manner, This PR change the config file directories from the universe to the autoware_launch.

Related links

part of this issue #1221

Tests performed

psim and tier4 internal tests

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yuki-takagi-66
prepare dir
6b0ffda 
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66
copy files from universe
3a304a0 
Signed-off-by: Yuki Takagi <[email protected]>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Oct 30, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: change the config file directories from the universe to the autoware_launch Oct 30, 2024
@yuki-takagi-66 yuki-takagi-66 changed the title chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: change the config file directories from the universe to the autoware_launch chore(diagnostic_graph_aggregator, system_diagnostic_monitor)!: change the config file directories from universe to autoware_launch Oct 30, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review October 30, 2024 10:48
isamu-takagi
isamu-takagi approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuki-takagi-66 yuki-takagi-66 merged commit 7f10766 into autowarefoundation:main Oct 31, 2024
16 of 17 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/diag/move-path-config branch October 31, 2024 09:29
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Oct 31, 2024
Merged
@xmfcx xmfcx mentioned this pull request Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@ito-san ito-san Awaiting requested review from ito-san ito-san is a code owner

Assignees

@isamu-takagi isamu-takagi

Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuki-takagi-66 @isamu-takagi