feat(psim, dummy_diag, diagnostic_graph_aggregator)!: launch dummy_diag_publisher

[yuki-takagi-66]

Description

This PR change to launch dummy_diag_publisher to use same diagnostic_graph_aggregator setting in psim.launch and autoware.launch.

Related links

part of this issue #1221

Tests performed

psim and scenario_simulator

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[isamu-takagi]

@yuki-takagi-66 I think the -psim files can be deleted. Is there any reason to leave them commented out?

[yukkysaito]

The purpose of the PR and the changes themselves look good. I haven’t verified the working.

[mitsudome-r]

I agree with Takagi-san.
We should either:

• remove the -psim file if we are not using them, or
• update the -psim file to match with the -main and keep using it

[yuki-takagi-66]

@isamu-takagi @mitsudome-r
Thank you for the comments.
I've delete the both "-psim.yaml" files.

[isamu-takagi]

LGTM

Before this PR

After this PR