Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rviz): add new plugin to show string stamped #139

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 30, 2024

Description

Add new rviz plugin to display the ROS message whose topic type is tier4_debug_msgs::msg::StringStamped in rviz.

image

movie-2024-10-30_10.58.22.mp4

The process of this tool is much lighter than overlay processes.

overlay occupies ~8% of rviz process.

image

this tool occupies ~0.5% of rviz process.

image

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota force-pushed the feat/add-simple-string-viewer branch from 4164304 to a3f152d Compare October 30, 2024 02:59
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota enabled auto-merge (squash) October 30, 2024 03:43
@satoshi-ota satoshi-ota merged commit a7d41b5 into main Oct 30, 2024
25 checks passed
@satoshi-ota satoshi-ota deleted the feat/add-simple-string-viewer branch October 30, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants