-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_lanelet_map_validator): add dangling reference checker to non existing intersection_area #177
feat(autoware_lanelet_map_validator): add dangling reference checker to non existing intersection_area #177
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
adae44c
to
7e22a32
Compare
…to non existing intersection_area Signed-off-by: Mamoru Sobue <[email protected]>
7e22a32
to
60ea165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the great work!
I wrote my opinions below so please check them out.
Aside those comments
- Could you write a brief document to explain what this validator can do?
- Could you add this to
autoware_requirement_set.json
like the following?
{
"id": "vm-03-01",
"validators": [
{
"name": "mapping.intersection.intersection_area_dangling_reference"
}
]
},
..._lanelet2_map_validator/src/validators/intersection/intersection_area_dangling_reference.cpp
Outdated
Show resolved
Hide resolved
..._lanelet2_map_validator/src/validators/intersection/intersection_area_dangling_reference.cpp
Show resolved
Hide resolved
..._lanelet2_map_validator/src/validators/intersection/intersection_area_dangling_reference.cpp
Show resolved
Hide resolved
map/autoware_lanelet2_map_validator/test/src/test_intersection_area_dangling_reference.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@soblin
Since the functionality is perfect, I'll approve this PR 👍
However I have some comments about the phrasing in the document so could you check them out? It also relates to the spelling check CI.
|
||
| Issue Code | Message | Severity | Primitive | Description | Approach | | ||
| -------------------------------------------------- | --------------------------------------------------------------------------------------- | -------- | --------- | ---------------------------------------------------------------------------------- | -------------------------------------------------------------------- | | ||
| Intersection.IntersectionAreaDanglingReference-001 | "Dangling reference to non-existing intersection area of ID \<LANELET ID\> is detected" | Error | Lanelet | Lookup to `intersection_area` from the reporeted lanelet will cause runtime error. | Go to the reported lanelet and delete "intersection_area" key entry. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookup to
intersection_area
from the reporeted lanelet will cause runtime error.
"The reported lanelet will cause a runtime error when attempting to look up the non-existent intersection_area.
" might be more clear.
|
||
## Feature | ||
|
||
This validator check whether each intersection lanelet(namely the lanelet with `turn_direction` property) has existing reference to `intersection_area` polygon. The countercase occurs when an existing intersection_area is deleted but its referrers are not updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- check -> checks
- I think the word
countercase
is not a popular word so how aboutcircumstance
oranomaly
?
map/autoware_lanelet2_map_validator/docs/intersection/intersection_area_dangling_reference.md
Outdated
Show resolved
Hide resolved
map/autoware_lanelet2_map_validator/docs/intersection/intersection_area_dangling_reference.md
Outdated
Show resolved
Hide resolved
…tion_area_dangling_reference.md
…tion_area_dangling_reference.md
Description
This PR aims to add checker if any intersection lanelets (namely with
turn_direction
tag) has valid VALUE as theintersection_area
key. If there are no intersection_area with corresponding VALUE id, it is dangling reference.How was this PR tested?
Added a test map "intersection_area_with_dangling_reference.osm" with:
Notes for reviewers
None.
Effects on system behavior
None.