feat(lanelet2_map_validator): generation script for new validators#180
Merged
TaikiYamada4 merged 14 commits intoautowarefoundation:mainfrom Dec 26, 2024
Conversation
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
soblin
approved these changes
Dec 26, 2024
Contributor
soblin
left a comment
There was a problem hiding this comment.
LGTM
ros2 run lanelet2_map_validator create_new.py <args> is also good
Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
+ Coverage 2.12% 38.40% +36.27%
==========================================
Files 163 27 -136
Lines 9402 638 -8764
Branches 383 379 -4
==========================================
+ Hits 200 245 +45
+ Misses 9045 178 -8867
- Partials 157 215 +58
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a tool to
autoware_lanelet2_map_validatorthat can generate necessary files to create a new validator which will be useful to contributors.This PR does the following.
templatedirectory and add templates for documents and test codes.validator_template.cppandvalidator_template.hpptotemplatecreate_new_validator.pythat can generate necessary files for a new validator.create_new_validator.pytohow_to_contribute.md.How was this PR tested?
Tested the following command at the
autoware_tools/map/autoware_lanelet2_map_validatordirectory, and checked four files are generated correctly.Then the output should be like
Notes for reviewers
None.
Effects on system behavior
None.