feat: add autoware msg bag converter#48
Closed
hayato-m126 wants to merge 8 commits intomainfrom
Closed
Conversation
hayato-m126
force-pushed
the
feat/add-autoware-msg-bag-converter
branch
from
5a9d9c1 to
c57ebd5
Compare
github-actions
Bot
added
component:common
component:planning
component:simulation
component:vehicle
component:localization
component:control
component:system
and removed
component:common
component:planning
component:simulation
component:vehicle
component:localization
component:control
component:system
labels
hayato-m126
force-pushed
the
feat/add-autoware-msg-bag-converter
branch
from
9348e2f to
59c34bd
Compare
hayato-m126
force-pushed
the
feat/add-autoware-msg-bag-converter
branch
from
bcfaad5 to
6118558
Compare
Contributor
SakodaShintaro
left a comment
SakodaShintaro
left a comment
There was a problem hiding this comment.
Thank you very much! I think it's basically fine.
However, let's wait until get approve from mitsudome-san before merging.
| type: git | ||
| url: https://github.com/autowarefoundation/autoware_common.git | ||
| version: main | ||
| core/external/autoware_auto_msgs: # TODO(mfc): Remove when autoware_msgs is merged |
Contributor
There was a problem hiding this comment.
I think it is okay to delete the comment as it seems unnecessary.
Contributor
Author
There was a problem hiding this comment.
I fixed with the following commit hash
4617d5e
| <package format="3"> | ||
| <name>autoware_msg_bag_converter</name> | ||
| <version>0.1.0</version> | ||
| <description>TODO: Package description</description> |
Contributor
There was a problem hiding this comment.
You should probably make a change because there is still a TODO left.
Contributor
Author
There was a problem hiding this comment.
I fixed with the following commit hash
95a2270
Contributor
Author
|
Since there is a dependency on autoware_auto_msg, cut it out as a separate branch instead of putting it in this repository |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added tool to convert bag containing autoware_auto_msg to autoware_msg
Related links
Tests performed
colcon test
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.