Added a new flow allowing to delegate to many nodes in a row #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreati
pushed a commit
to moreati/wallet-site
that referenced
this pull request
Feb 24, 2022
Support more than 1024 addresses for atomic imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to delegate to many nodes in one flow:
The purpose of the PR is to make it easier for people to like to diversify the delegate nodes to diminish the risk of nodes being taken down, especially in times of instability like these days.
Aside from this change, I also fixed the same P-CHAIN address being used over and over again when delegating during the same session, this fix is to enforce BIP-32 thus, increasing security and privacy, as no node will be able to tell how much balance you carry easily.
Added a new localization key:
I'm not sure what's the process to add the translation for this key, if anyone could point me to it, I'll gladly add the locas there, the meant loca for english is just "Finish"