Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Sep 22, 2025

Why this should be merged

There are packages in subnet-evm and coreth that share a lot of functionality / are mirrored. These packages should be uplifted to AvalancheGo to prevent the duplicative maintenance of two sets of the same code. I recently was syncing changes between coreth and subnet-evm for these gossip changes, and it would be better if this code was just in AvalancheGo

Here are the packages being unified and uplifted:
coreth: https://github.com/ava-labs/coreth/tree/master/plugin/evm/gossip
subnet-evm: https://github.com/ava-labs/subnet-evm/tree/master/plugin/evm/gossip

How this was tested

This is currently 'dead' code; after a new AvalancheGo release is dropped, we can use the code in the evm repositories.

Need to be documented in RELEASES.md?

No

Copilot AI review requested due to automatic review settings September 22, 2025 18:00
@JonathanOppenheimer JonathanOppenheimer self-assigned this Sep 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR uplifts the gossip package from EVM repositories (subnet-evm and coreth) to AvalancheGo to reduce code duplication and maintenance overhead. The change introduces a new transaction gossip handler that combines push and pull gossip functionality with throttling and validator filtering.

Key changes:

  • Adds a new gossip package under vms/evm/ containing a transaction gossip handler
  • Implements a composite handler that wraps both app gossip and app request handlers with different access controls

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@JonathanOppenheimer JonathanOppenheimer moved this to Ready 🚦 in avalanchego Sep 22, 2025
@JonathanOppenheimer JonathanOppenheimer changed the title uplift: Add gossip package from evm repositories uplift: add gossip package from evm repositories Oct 23, 2025
@JonathanOppenheimer JonathanOppenheimer changed the title uplift: add gossip package from evm repositories uplift gossip package from evm repositories Oct 23, 2025
@ARR4N
Copy link
Contributor

ARR4N commented Oct 28, 2025

Is this the "temporary" directory, or is it the final destination for this code? If the latter, I'll provide more thorough comments on style.

@JonathanOppenheimer
Copy link
Member Author

JonathanOppenheimer commented Oct 28, 2025

Is this the "temporary" directory, or is it the final destination for this code? If the latter, I'll provide more thorough comments on style.

This is the final destination for the code. 'uplifting' is the is the process of cleaning up, aligning with AvalancheGo standards, etc. so these typically get more thorough reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready 🚦

Development

Successfully merging this pull request may close these issues.

4 participants