Move ginkgo tool usage to the main go.mod from tools/go.mod #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI logs were reporting that the version of the ginkgo CLI was divergent from the version used by our test suites. Since most of ginkgo's dependencies are already represented in the main module, the risk of unwanted dependency pollution is low and managing ginkgo only in the main module avoids having to synchronize the version across the 2 modules.
maru-ava
requested review from
joshua-kim and
StephenButtolph
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR moves ginkgo tool management from tools/go.mod to the main go.mod to address CI issues with version divergence between the ginkgo CLI and test suite dependencies.
- Removed ginkgo tool dependency from tools/go.mod
- Added ginkgo as a tool dependency in the main go.mod
- Updated the ginkgo execution script to use
go tool ginkgoinstead of the tools module approach
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/go.mod | Removed ginkgo tool and related indirect dependencies |
| go.mod | Added ginkgo as a tool dependency and updated related dependency versions |
| scripts/run_ginkgo.sh | Modified to use go tool ginkgo directly from main module |
| .github/CODEOWNERS | Added ownership rule for tools directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maru-ava
commented
Sep 24, 2025
| /tests/ @joshua-kim @maru-ava | ||
| /tests/*.md @joshua-kim @maru-ava @meaghanfitzgerald | ||
| /tests/reexecute/ @aaronbuchwald | ||
| /tools/* @joshua-kim @maru-ava |
There was a problem hiding this comment.
Forgot to add this in the PR moving CLI tooling to go tool.
maru-ava
force-pushed
the
marun/main-module-ginkgo
branch
from
6ed57c9 to
598d441
Compare
maru-ava
commented
Sep 24, 2025
joshua-kim
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
CI logs were reporting that the version of the ginkgo CLI was divergent from the version used by our test suites. Since most of ginkgo's dependencies are already represented in the main module, the risk of unwanted dependency pollution is low and managing ginkgo only in the main module avoids having to synchronize the version across the 2 modules.
How this was tested
CI
Need to be documented in RELEASES.md?
N/A