Skip to content

Conversation

ceyonur
Copy link
Contributor

@ceyonur ceyonur commented Sep 25, 2025

Why this should be merged

The check was too strict, it should only cover those potentially can be imported from subnet-evm

How this works

relaxes the test by only checking:

  • direct tests package
  • direct tests/antithesis package
  • tests/fixture and subpackages

How this was tested

UT

Need to be documented in RELEASES.md?

no

@ceyonur ceyonur requested a review from joshua-kim as a code owner September 25, 2025 18:50
@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 18:50
@ceyonur ceyonur requested a review from maru-ava as a code owner September 25, 2025 18:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR relaxes the import validation rules for the test packages to be more specific about which packages should not import certain coreth-related libraries. Instead of broadly restricting all test packages, it now only restricts specific test directories that could potentially be imported by subnet-evm.

  • Extracts forbidden import paths into a reusable slice for better maintainability
  • Replaces the broad tests/... restriction with specific restrictions for tests/, tests/antithesis/, and tests/fixture/...

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ceyonur ceyonur changed the title use only relevant package to subnet-evm test only relevant packages for subnet-evm Sep 25, 2025
@ceyonur ceyonur requested a review from maru-ava September 26, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants