fix: blockdb has block don't error if invalid block height #4354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fix the behaviour of
HasBlock
inx/blockdb
. Currently if request a block below the min height of the database or a large block height that is not supported by the index file, then it returns anErrInvalidBlockHeight
error. Instead, we should just returnfalse
with no error as that makes more sense.How this works
Treat both
ErrInvalidBlockHeight
andErrBlockNotFound
as expected errors forHasBlock
How this was tested
Add unit tests for HasBlock behaviour
Need to be documented in RELEASES.md?