Fix flake in TestWaitForEvent/WaitForEvent_build_block_after_re-org
#4789
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yacov Manevich <[email protected]>
Signed-off-by: Yacov Manevich <[email protected]>
This reverts commit ef3c797.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a flaky test by increasing the context timeout in TestWaitForEvent from 2 to 5 seconds. The test was experiencing intermittent failures on overloaded machines because the 2-second timeout was too close to the internal 2-second wait period, causing the context to expire prematurely in edge cases.
- Increased timeout from 2 to 5 seconds to provide sufficient buffer for the internal wait operation
- Prevents context deadline expiration on slower/overloaded systems
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yacovm
changed the title
TestWaitForEvent/WaitForEvent_build_block_after_re-org
JonathanOppenheimer
approved these changes
Dec 31, 2025
Member
|
Closes #4757 |
JonathanOppenheimer
requested changes
Jan 12, 2026
Member
JonathanOppenheimer
left a comment
JonathanOppenheimer
left a comment
There was a problem hiding this comment.
Can you change the test timeout in coreth as well?
Signed-off-by: Yacov Manevich <[email protected]>
JonathanOppenheimer
approved these changes
Jan 12, 2026
DracoLi
approved these changes
Jan 12, 2026
maru-ava
approved these changes
Jan 13, 2026
Contributor
maru-ava
left a comment
maru-ava
left a comment
There was a problem hiding this comment.
Super smelly to rely on tight timing instead of state validation, so hopefully this goes away at some point in the not-too-distant future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes the flake by giving more time. The wait for event internally waits for 2 seconds and the deadline for the context is also 2 seconds which is borderline in times where the machine is overloaded and the context may expire too soon even though it should've succeeded.
How this works
Increases the timeout.
How this was tested
Commented out the other tests and ran the test 1000 times in parallel in a loop. Can be seen here.
Need to be documented in RELEASES.md?