Skip to content

feat(vm_reexecute): add pprof profiling support #4790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Elvis339 wants to merge 7 commits into
base: master
Choose a base branch
from
+20 −4
Open

feat(vm_reexecute): add pprof profiling support #4790

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4786b42
feat(vm_reexecute): add pprof profiling support with CPU and memory p…
Elvis339 Dec 25, 2025
3745c1f
feat(benchmark_cchain)
Elvis339 Dec 25, 2025
53b601a
lint
Elvis339 Dec 25, 2025
bd6bf20
chore(benchmark_cchain): pprof flag, in the subsequent PRs PPROF shou…
Elvis339 Dec 25, 2025
7f0d933
chore(vm_reexecute): refactor pprof setup to use unified profiler uti…
Elvis339 Jan 5, 2026
1b5ea63
chore(vm_reexecute): replace pprofEnabled flag with pprofDirArg for f…
Elvis339 Jan 5, 2026
823252f
chore: revert doc changes to benchmark_cchain_range.sh
Elvis339 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions tests/reexecute/c/vm_reexecute.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (
"github.com/ava-labs/avalanchego/tests/reexecute"
"github.com/ava-labs/avalanchego/utils/logging"
"github.com/ava-labs/avalanchego/utils/perms"
"github.com/ava-labs/avalanchego/utils/profiler"
"github.com/ava-labs/avalanchego/utils/timer"
)

Expand All @@ -42,6 +43,7 @@ var (
executionTimeout time.Duration
labelsArg string

pprofDirArg string
metricsServerEnabledArg bool
metricsServerPortArg uint64
metricsCollectorEnabledArg bool
Expand Down Expand Up @@ -92,6 +94,7 @@ func init() {
flag.IntVar(&chanSizeArg, "chan-size", 100, "Size of the channel to use for block processing.")
flag.DurationVar(&executionTimeout, "execution-timeout", 0, "Benchmark execution timeout. After this timeout has elapsed, terminate the benchmark without error. If 0, no timeout is applied.")

flag.StringVar(&pprofDirArg, "pprof-dir", "", "Directory to write cpu, mem, and lock profiles. Empty to disable.")
flag.BoolVar(&metricsServerEnabledArg, "metrics-server-enabled", false, "Whether to enable the metrics server.")
flag.Uint64Var(&metricsServerPortArg, "metrics-server-port", 0, "The port the metrics server will listen to.")
flag.BoolVar(&metricsCollectorEnabledArg, "metrics-collector-enabled", false, "Whether to enable the metrics collector (if true, then metrics-server-enabled must be true as well).")
Expand Down Expand Up @@ -205,20 +208,33 @@ func benchmarkReexecuteRange(
)

log := tc.Log()
log.Info("re-executing block range with params",
logFields := []zap.Field{
zap.String("runner", runnerTypeArg),
zap.String("config", configNameArg),
zap.String("labels", labelsArg),
zap.String("metrics-server-enabled", strconv.FormatBool(metricsServerEnabled)),
zap.Bool("metrics-server-enabled", metricsServerEnabled),
zap.Uint64("metrics-server-port", metricsPort),
zap.String("metrics-collector-enabled", strconv.FormatBool(metricsCollectorEnabled)),
zap.Bool("metrics-collector-enabled", metricsCollectorEnabled),
zap.String("block-dir", blockDir),
zap.String("vm-db-dir", vmDBDir),
zap.String("chain-data-dir", chainDataDir),
zap.Uint64("start-block", startBlock),
zap.Uint64("end-block", endBlock),
zap.Int("chan-size", chanSize),
)
}

if pprofDirArg != "" {
p := profiler.New(pprofDirArg)
r.NoError(p.StartCPUProfiler())
defer func() {
r.NoError(p.StopCPUProfiler())
r.NoError(p.MemoryProfile())
r.NoError(p.LockProfile())
}()

logFields = append(logFields, zap.String("pprof-dir", pprofDirArg))
}
log.Info("re-executing block range with params", logFields...)

blockChan, err := reexecute.CreateBlockChanFromLevelDB(tc, blockDir, startBlock, endBlock, chanSize)
r.NoError(err)
Expand Down