fix: Always register Firewood metrics when enabled #4793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures Firewood metrics are always registered when Firewood is enabled, rather than conditionally based on the MetricsExpensiveEnabled flag. The initialization of metrics is moved to an init() function to avoid errors from multiple calls to ffi.StartMetrics() during testing.
Key changes:
- Moved
ffi.StartMetrics()call to aninit()function in a newmetrics.gofile - Removed the
MetricsExpensiveEnabledcondition from metric registration logic - Simplified error messages for metric registration failures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| graft/evm/firewood/metrics.go | New file introducing init() function to start Firewood metrics once per process |
| graft/subnet-evm/plugin/evm/vm.go | Removed conditional check for expensive metrics and simplified registration logic |
| graft/coreth/plugin/evm/vm.go | Removed conditional check for expensive metrics and simplified registration logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanOppenheimer
approved these changes
Jan 6, 2026
maru-ava
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Firewood metrics aren't particularly expensive, and there's a ticket to expose more expensive metrics within Firewood. It should always be registered.
How this works
ffi.StartMetricscan only be called once per process, otherwirse it returns an error. This is a problem for tests, so this is moved to an init function, guaranteeing it will only happen once.How this was tested
Locally, to ensure metrics are still scrapable.
Need to be documented in RELEASES.md?
No.