refactor: directly embed files in graft
#4795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
added
cleanup
alarso16
approved these changes
Jan 2, 2026
maru-ava
reviewed
Jan 6, 2026
| genesisPath := filepath.Join(testDir, "genesis.json") | ||
|
|
||
| var err error | ||
| repoRoot, err = e2e.GetRepoRootPath("tests/load") |
Contributor
There was a problem hiding this comment.
I'm ok with continuing to use GetRepoRootPath for now, but ideally we remove the need for it going forward (i.e. by checking for the run_simulator.sh script via a relative path and if missing require an absolute path to be provided by a flag).
Member
Author
There was a problem hiding this comment.
I will do a follow up PR to accomplish this! and remove the function entirely so no one else can use it.
maru-ava
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #4776 -- this is a pretty nice clean up IMO. Credit to Maru for raising the issue.
How this works
One thing to note that is that embed declaration only work for files at the same level directory. See golang/go#46056. So I created a single file to embed the shared genesis file and then imported it.
How this was tested
CI
Need to be documented in RELEASES.md?
No