-
Notifications
You must be signed in to change notification settings - Fork 845
refactor: warp e2e tests no longer in single function #4798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
No action required: the context created in |
Nah this is a great catch! I will make this change |
Why this should be merged
This refactors the warp e2e tests in both subnet-evm and coreth to use a more standard ginkgo test structure (close to the one suggested by @michaelkaplan13 ). This provides better failure isolation by breaking each test functionality into its own
Itblock within orderedDescribeblocks for each test combination.Closes #4699
How this works
Explicitly defined test combinations.
How this was tested
CI
Need to be documented in RELEASES.md?
No