Skip to content

Conversation

@JonathanOppenheimer
Copy link
Member

Why this should be merged

This refactors the warp e2e tests in both subnet-evm and coreth to use a more standard ginkgo test structure (close to the one suggested by @michaelkaplan13 ). This provides better failure isolation by breaking each test functionality into its own It block within ordered Describe blocks for each test combination.

Closes #4699

How this works

Explicitly defined test combinations.

How this was tested

CI

Need to be documented in RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer self-assigned this Dec 31, 2025
@JonathanOppenheimer JonathanOppenheimer added the evm Related to EVM functionality label Dec 31, 2025
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner December 31, 2025 21:03
@JonathanOppenheimer JonathanOppenheimer added coreth Related to the former coreth standalone repository subnet-evm Related to the former subnet-evm standalone repository labels Dec 31, 2025
@Elvis339
Copy link
Contributor

Elvis339 commented Jan 2, 2026

No action required: the context created in BeforeAll is used for newWarpTest initialization, including IssueTxsToActivateProposerVMFork which waits for transactions. If BeforeAll has a shorter timeout than It blocks, this could potentially cause timeout issues. Maybe consider having newWarpTest create its own context like the other methods do. Not blocking if this hasn't caused issues in practice just my two cents.

@JonathanOppenheimer
Copy link
Member Author

No action required: the context created in BeforeAll is used for newWarpTest initialization, including IssueTxsToActivateProposerVMFork which waits for transactions. If BeforeAll has a shorter timeout than It blocks, this could potentially cause timeout issues. Maybe consider having newWarpTest create its own context like the other methods do. Not blocking if this hasn't caused issues in practice just my two cents.

Nah this is a great catch! I will make this change

@maru-ava maru-ava added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 18e704e Jan 7, 2026
53 checks passed
@maru-ava maru-ava deleted the JonathanOppenheimer/refactor-warp-e2e branch January 7, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreth Related to the former coreth standalone repository evm Related to EVM functionality subnet-evm Related to the former subnet-evm standalone repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor warp e2e test to avoid a single sequential function

5 participants