refactor: Firewood Config helper #4811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
added
cleanup
Contributor
There was a problem hiding this comment.
Pull request overview
This refactoring improves the Firewood configuration helper by renaming fields for better clarity and introducing a DefaultConfig constructor function. The changes simplify configuration setup across test and production code by providing a single function to create default configurations with a specified directory path.
Key changes:
- Renamed configuration fields (
ChainDataDir→DatabasePath,CleanCacheSize→CacheSizeBytes,Revisions→RevisionsInMemory,ReadCacheStrategy→CacheStrategy,ArchiveMode→Archive) - Replaced the
Defaultsvariable with aDefaultConfig(dir string)constructor function - Exported the internal
fwDiskfield asFirewoodto allow read access to the underlying database
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| graft/evm/firewood/triedb.go | Refactored Config struct with clearer field names, added DefaultConfig constructor, and exported Firewood database field |
| graft/subnet-evm/core/blockchain.go | Updated to use renamed Config fields and inline default value for FreeListCacheEntries |
| graft/coreth/core/blockchain.go | Updated to use renamed Config fields and inline default value for FreeListCacheEntries |
| graft/subnet-evm/tests/state_test_util.go | Simplified configuration by using new DefaultConfig constructor |
| graft/coreth/tests/state_test_util.go | Simplified configuration by using new DefaultConfig constructor |
| graft/subnet-evm/core/genesis_test.go | Simplified test configuration by using new DefaultConfig constructor |
| graft/coreth/core/genesis_test.go | Simplified test configuration by using new DefaultConfig constructor |
| graft/evm/firewood/hash_test.go | Simplified test configuration by using new DefaultConfig constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanOppenheimer
approved these changes
Jan 6, 2026
RodrigoVillar
approved these changes
Jan 6, 2026
maru-ava
reviewed
Jan 6, 2026
maru-ava
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is a small diff pulled out of #4697 to support state sync test for Firewood.
How this works
Renames some fields for clarity, provides a simpler construction method, and exports the underlying database
How this was tested
Existing UT
Need to be documented in RELEASES.md?
No