chore: retype DelayExcess
#4833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ptr-to Signed-off-by: Jonathan Oppenheimer <[email protected]>
…thanOppenheimer/cleanup-ptr-to
This reverts commit 17d7a81.
Comment on lines
+26
to
+28
| InitialDelayExcess DelayExcess = 7_970_124 | ||
|
|
||
| maxDelayExcess = 46_516_320 // ConversionRate * ln(MaxUint64 / MinDelayMilliseconds) + 1 | ||
| maxDelayExcess DelayExcess = 46_516_320 // ConversionRate * ln(MaxUint64 / MinDelayMilliseconds) + 1 |
Member
Author
There was a problem hiding this comment.
Here are the important changes.
…eimer/delay-excess-retype Signed-off-by: Jonathan Oppenheimer <[email protected]>
…eimer/delay-excess-retype Signed-off-by: Jonathan Oppenheimer <[email protected]>
DracoLi
approved these changes
Jan 13, 2026
alarso16
approved these changes
Jan 13, 2026
Signed-off-by: Jonathan Oppenheimer <[email protected]>
maru-ava
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This is a follow up to PR #4741. While working on that PR, the pointers to
acp226.DelayExcesswere sort of ugly because they were never explicitly typed. This PR cleans that up by typing them.How this was tested
CI
Need to be documented in RELEASES.md?
No