Skip to content

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Sep 25, 2025

Description

Ticket: CP-12145

iOS build: https://avalancheavax.slack.com/archives/C03U8L93F6E/p1758817140987819
Android build: https://avalancheavax.slack.com/archives/C03U8L93F6E/p1758817953797069

Please provide:

  • call LocalAuthentication.authenticateAsync to always show the biometric prompt on pin screen overlay component
  • add isInitialLogin prop to PinScreen and UsePinOrBiometryLogin to only run migration and other tasks that is only needed on initial app launch
  • add onBiometricPrompt to handle different biometric action for PinScreenOverlay or loginWithPinOrBiometric screen

Screenshots/Videos

Include relevant screenshots or screen recordings of iOS and Android.

iOS:
https://github.com/user-attachments/assets/8c8038c3-dec3-4c88-a881-8a27f4b0e6ba

Android:

IMG_7179.mov

Testing

Dev Testing (if applicable)

  • launch and unlock the app, then let the screen timeout on android or iOS device. after 1 minutes (assuming the timeout setting in system is 30 secs or les), unlock the device, the app should always show the pin screen.

QA Testing (if applicable)

  • Provide instructions for QA to test this feature thoroughly
  • State expected behavior / acceptance criteria

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have included screenshots / videos of android and ios
  • I have added testing steps
  • I have added/updated necessary unit tests
  • I have updated the documentation

Comment on lines 428 to 430
async isEnrolledAsync(): Promise<boolean> {
return LocalAuthentication.isEnrolledAsync()
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to expose this method?

atn4z7
atn4z7 previously approved these changes Sep 25, 2025
Copy link
Collaborator

@atn4z7 atn4z7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev tested:

  • change pin ✅
  • device timeout ✅
  • app goes to background -> foreground ✅
  • initial unlock ✅
  • onboarding ✅

atn4z7
atn4z7 previously approved these changes Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants