Add native crypto lib #3314
Open
Add native crypto lib #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # yarn.lock fix set problems stash work # Conflicts: # yarn.lock stash work # Conflicts: # packages/core-mobile/index.js performance tracking # Conflicts: # yarn.lock stash work make it more solid fix patch for ios update sentry fix patches
gugell
requested review from
B0Y3R-AVA,
atn4z7,
bogdandobritoiu,
onghwan and
ruijialin-avalabs
as code owners
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
from
3a99462 to
2f2e959
Compare
atn4z7
reviewed
Nov 17, 2025
Collaborator
There was a problem hiding this comment.
can you remove these wallet connect patches? they should already be the other wallet connect pr.
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
atn4z7
reviewed
Nov 17, 2025
packages/core-mobile/metro.config.js
Outdated
| stream: require.resolve('./node_modules/stream-browserify'), | ||
| '@noble/hashes': require.resolve('./node_modules/@noble/hashes') | ||
| '@noble/hashes': require.resolve('./node_modules/@noble/hashes'), | ||
| "react-native-nitro-avalabs-crypto": nitroCryptoPath |
Collaborator
There was a problem hiding this comment.
I don't think you need to declare react-native-nitro-avalabs-crypto here. it should already be picked up automatically by metro since it belongs to this workspace.
atn4z7
reviewed
Nov 17, 2025
Comment on lines
46
to
49
| nodeModulesPaths: [ | ||
| path.resolve(workspaceRoot, 'node_modules'), | ||
| path.resolve(projectRoot, 'node_modules'), | ||
| ], |
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
6 times, most recently
from
b8c5e23 to
24d1dd5
Compare
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
from
24d1dd5 to
bda4068
Compare
# Conflicts: # packages/core-mobile/android/app/src/main/AndroidManifest.xml # yarn.lock
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
from
0688ea9 to
865584d
Compare
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
from
8b63168 to
ce5e3bc
Compare
atn4z7
reviewed
Nov 24, 2025
| "clean": "rm -rf android/build node_modules/**/android/build lib", | ||
| "lint": "eslint \"**/*.{js,ts,tsx}\" --fix", | ||
| "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions", | ||
| "typescript": "tsc", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "typescript": "tsc", | |
| "tsc": "tsc", |
since we run yarn tsc for all packages in this repo
atn4z7
reviewed
Nov 24, 2025
Comment on lines
34
to
35
| "lint": "eslint \"**/*.{js,ts,tsx}\" --fix", | ||
| "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "lint": "eslint \"**/*.{js,ts,tsx}\" --fix", | |
| "lint-ci": "eslint \"**/*.{js,ts,tsx}\" -f @jamesacarr/github-actions", | |
| "lint": "eslint .", |
let's keep only 1 lint here. no need for the --fix also since we already do that when committing.
atn4z7
reviewed
Nov 24, 2025
| "README.md" | ||
| ], | ||
| "scripts": { | ||
| "postinstall": "tsc || exit 0;", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "postinstall": "tsc || exit 0;", |
I don't think we need to run typescript post install
atn4z7
reviewed
Nov 24, 2025
Comment on lines
76
to
93
| "eslintConfig": { | ||
| "root": true, | ||
| "extends": [ | ||
| "@react-native", | ||
| "prettier" | ||
| ], | ||
| "plugins": [ | ||
| "prettier" | ||
| ], | ||
| "rules": { | ||
| "prettier/prettier": [ | ||
| "warn", | ||
| { | ||
| "quoteProps": "consistent", | ||
| "singleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "es5", | ||
| "useTabs": false |
Collaborator
There was a problem hiding this comment.
we already have our own lint setup actually so there is no need to specify eslint rules here. could you follow the same setup as in the packages in this repo? an example is the packages/k2-alpine/.eslintrc.js
atn4z7
reviewed
Nov 24, 2025
| @@ -0,0 +1 @@ | |||
| export * from './Crypto'; No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
there are 2 index files. looks like one can be removed
atn4z7
reviewed
Nov 24, 2025
| if (len & 0x80) { | ||
| const n = len & 0x7f | ||
| if (n === 0 || n > 2) throw new TypeError('Invalid DER: long len too big') | ||
| if (p + n > sig.length) throw new TypeError('Invalid DER: length overflow') |
Collaborator
There was a problem hiding this comment.
can you add tests for these functions?
gugell
force-pushed
the
@szymon/nativeCryptoLib
branch
from
a9e1f6b to
1e11650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces native Nitro crypto integration for React Native, updates cryptography dependencies to use patched versions with native support, and improves monorepo compatibility and configuration for the mobile app. The main changes focus on enabling fast, native-backed cryptographic operations (ECDSA, Schnorr) in the mobile environment, updating dependency patching for
@noble/curvesand@bitcoinerlab/secp256k1, and ensuring the Metro bundler is aware of the new native crypto workspace.Native crypto integration and dependency patching:
@bitcoinerlab/secp256k1and@noble/curvesvia custom patches, allowing operations likesign,verify,signSchnorr, andverifySchnorrto use thereact-native-nitro-avalabs-cryptomodule when available, with fallback to JS implementations. (.yarn/patches/@bitcoinerlab-secp256k1-npm-1.2.0-1098d4b329.patch[1].yarn/patches/@noble-curves-npm-1.9.7-2b9efc8ab4.patch[2]package.jsonto patch all references to@noble/curvesand@bitcoinerlab/secp256k1to ensure the mobile app uses the Nitro-enabled versions. (package.jsonpackage.jsonL55-R73)Monorepo and Metro configuration:
packages/core-mobile/metro.config.jsto add the Nitro crypto workspace to Metro's watch folders and resolver, ensuring correct module resolution for the new native crypto module. (packages/core-mobile/metro.config.js[1] [2]react-native-nitro-avalabs-cryptoas a workspace dependency inpackages/core-mobile/package.json. (packages/core-mobile/package.jsonpackages/core-mobile/package.jsonR202-R203)Platform compatibility and workflow improvements:
package.jsonfiles, improving compatibility across platforms. (.yarn/patches/@bitcoinerlab-secp256k1-npm-1.2.0-1098d4b329.patch[1].yarn/patches/@noble-curves-npm-1.9.7-2b9efc8ab4.patch[2].yarn/patches/jail-monkey-npm-2.8.0-77e4d06b40.patch[3]autoconf,automake,libtool) for native module compilation. (bitrise.ymlbitrise.ymlR218-R220)Minor improvements and fixes:
package.json. (package.jsonpackage.jsonR16).yarn/patches/jail-monkey-npm-2.8.0-77e4d06b40.patch.yarn/patches/jail-monkey-npm-2.8.0-77e4d06b40.patchL19-R31)These changes collectively enable high-performance native cryptography for React Native, ensure correct dependency resolution across the monorepo, and improve platform compatibility for mobile builds.
Testing
Dev Testing (if applicable)
QA Testing (if applicable)
Checklist
Please check all that apply (if applicable)