fix(benchmark/bootstrap): update script to use new task #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demosdemon
requested changes
Jan 9, 2026
benchmark/bootstrap/aws-launch.sh
Outdated
| - > | ||
| sudo -u ubuntu -D /mnt/nvme/ubuntu/avalanchego --login | ||
| time METRICS_SERVER_ENABLED=__METRICS_SERVER__ task reexecute-cchain-range CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__ | ||
| METRICS_SERVER_ENABLED=__METRICS_SERVER__ CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__ time task test-cchain-reexecution |
Contributor
There was a problem hiding this comment.
time needs to be first. it's similar to env; it is a command built into the shell and has different semantics than when invoking a normal command.
Suggested change
| METRICS_SERVER_ENABLED=__METRICS_SERVER__ CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__ time task test-cchain-reexecution | |
| time METRICS_SERVER_ENABLED=__METRICS_SERVER__ CURRENT_STATE_DIR=/mnt/nvme/ubuntu/exec-data/current-state BLOCK_DIR=/mnt/nvme/ubuntu/exec-data/blocks START_BLOCK=1 END_BLOCK=__END_BLOCK__ CONFIG=__CONFIG__ task test-cchain-reexecution |
demosdemon
approved these changes
Jan 9, 2026
RodrigoVillar
deleted the
rodrigo/update-bootstrap-script-with-new-task
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
With ava-labs/avalanchego#4761, invocation of the reexecution test underwent a major refactor. Running the current bootstrap script against the latest version of AvalancheGo results in an error.
How this works
Updates bootstrapping script to use the new invocation of the reexecution test.
How this was tested
Ran
./aws-launch.sh --firewood-branch main --avalanchego-branch master --libevm-branch b8e76562a300 --nblocks 1mand observed a successful reexecution test.