Replace full blocks with headers in hook.Points #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
force-pushed
the
StephenButtolph/simplify-hooks
branch
from
83e18db to
af596f7
Compare
ARR4N
reviewed
Dec 8, 2025
| // | ||
| // For example, if the block timestamp is 10.75 seconds and the gas rate is | ||
| // 100 gas/second, then this method should return 75 gas. | ||
| SubSecondBlockTime(*types.Header) gas.Gas |
Collaborator
There was a problem hiding this comment.
We're going to need a SetSubSecondBlockTime() too, aren't we? Not necessarily here, but just thinking out loud.
Contributor
Author
There was a problem hiding this comment.
I didn't think we would need to do that, but I suppose it depends on how we are planning on constructing the header.
Collaborator
There was a problem hiding this comment.
I assumed it would have to be in a libevm extra payload, and we don't want to do any libevm registration in SAE as that would stop consumers from being able to.
ARR4N
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During block building, we do not have a full block to provide to the
Pointsinterface. All of the required fields are in the header anyways, so this really just simplifies the implementation as well.