Fix invalid pointer dereference in extract_ms_counter_certs
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, however I think this problem struck into a thing that needs slight bigger modification. As now MS counter signature can be both PKCS7 and CMS with the latest changes. I will look into it, I need to recollect why the code is written this way :D |
|
I've created PR #21 that supersedes this fix. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if this fix is correct. It certainly prevents the SIGSEGV with file
e9b3cadbd8fdb7a26a7130e7b40d4a99632fa6f767b0339385e5786d66015cfb, but I don't know if it is logically correct.Closes #19