Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added spiritor ai #5323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added spiritor ai #5323

wants to merge 1 commit into from

Conversation

gregtzar
Copy link

@gregtzar gregtzar commented May 29, 2024

Developer Comments

Hey there. I am the developer/maintainer for this library. I just wanted to note that I do not have CI and/or unit testing running yet (hence the unchecked boxes below) but plan to in the future. This is challenging though, because this app is primarily a CLI that reads/writes from the local filesystem and building unit tests is a challenge. I need to research and figure out the best testing strategy for a package like this and that will be happening as the project progresses.

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • The repo documentation has a pkg.go.dev link.
  • The repo documentation has a coverage service link.
  • The repo documentation has a goreportcard link.
  • The repo has a version-numbered release and a go.mod file.
  • The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • The package has been added to the list in alphabetical order.
  • The package has an appropriate description with correct grammar.
  • As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • The packages around my addition still meet the Quality Standards.
  • I removed the following packages around my addition: (please give a short reason for each removal)

Thanks for your PR, you're awesome! 😎

Summary by CodeRabbit

  • Documentation
    • Added SpiritorAI, a privacy-centric and open-source toolkit for writers and content creators, to the list of AI libraries in the README.

sourcery-ai[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

@phanirithvij
Copy link
Collaborator

Your project is too new, it's only been 4 days. I don't think it is stable enough. Please resubmit once you write tests, and it reaches a stable 1.0

@gregtzar
Copy link
Author

gregtzar commented Jun 1, 2024

@phanirithvij Seriously? There's a ton of packages on your list that are still in v0.x.x. Being in v1.x.x isn't even a requirement in any of your docs. I may have only published this a few days ago but it's been around for a while. Lame.

@phanirithvij
Copy link
Collaborator

phanirithvij commented Jun 1, 2024

Sorry I shouldn't have closed it.

I know there are bad entries, cleaning up is not easy. It's not possible to automate cleaning up properly. I will remove those entries.

There is a requirement in the contributing guide in the quality standards

be stable or progressing toward stable;

But sure it's not exactly v1.0.0.

Repository owner deleted a comment from github-actions bot Jun 1, 2024
Repository owner deleted a comment from coderabbitai bot Jun 1, 2024
@Preacher27

This comment was marked as spam.

@Preacher27

This comment was marked as spam.

@k-capehart
Copy link
Contributor

k-capehart commented Jun 19, 2024

@phanirithvij Go's own documentation states that a project is stable once it has reached v1.0.0. Maybe worth pointing out in the guidelines.

https://go.dev/doc/modules/version-numbers

image

@phanirithvij phanirithvij self-assigned this Jun 20, 2024
@phanirithvij
Copy link
Collaborator

@k-capehart thank you. I remember seeing it somewhere but forgot where.

@Preacher27
Copy link

Preacher27 commented Jun 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants