Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product options #462

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Product options #462

wants to merge 13 commits into from

Conversation

SagarKarwande
Copy link
Member

Why?

There was necessity to support the different options for creating a product.

This change addresses the need by:

[delivers #pivotal_story_id]

Checklist

  • I have read CONTRIBUTING.md.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • My code does not generate any (new) credo and compile-time warnings.
  • I have updated the documentation wherever necessary.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #462 into develop will increase coverage by 0.67%.
The diff coverage is 30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
+ Coverage    78.11%   78.78%   +0.67%     
===========================================
  Files          174      175       +1     
  Lines         2138     2234      +96     
===========================================
+ Hits          1670     1760      +90     
- Misses         468      474       +6
Impacted Files Coverage Δ
apps/snitch_core/lib/core/data/schema/product.ex 89.65% <ø> (ø) ⬆️
...ps/snitch_core/lib/core/data/schema/option_type.ex 0% <ø> (-25%) ⬇️
...core/lib/core/data/schema/template_option_value.ex 0% <ø> (ø) ⬆️
...core/lib/core/tools/elasticsearch/product/store.ex 36.84% <ø> (ø) ⬆️
...e/lib/core/tools/elasticsearch/product/document.ex 72.54% <0%> (ø) ⬆️
...h_core/lib/core/data/model/product_option_value.ex 0% <0%> (ø) ⬆️
...nitch_core/lib/core/data/schema/variation_theme.ex 55.55% <100%> (ø) ⬆️
.../snitch_core/lib/core/data/schema/option_values.ex 66.66% <100%> (ø)
...pps/snitch_core/lib/core/data/model/option_type.ex 40% <14.28%> (ø) ⬆️
apps/snitch_core/lib/core/data/schema/option.ex 25% <25%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa48314...5ea627b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant