Fixes Colliders not properly removing their collisions when they get disabled, moved and enabled.#890
Open
TheSylex wants to merge 1 commit intoavianphysics:mainfrom
Open
Fixes Colliders not properly removing their collisions when they get disabled, moved and enabled.#890TheSylex wants to merge 1 commit intoavianphysics:mainfrom
TheSylex wants to merge 1 commit intoavianphysics:mainfrom
Conversation
Author
|
After further testing I've noticed that even though this change fixes the error it mentions it now creates another strange behavior that I can't yet fully articulate. But basically now it seems like when not Disabling entities at all sometimes Entering/Exiting collisions don't trigger at all :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Whenever a Collider is disabled and moved away from a position, the collisions that it was triggering will come back to being active as soon as the Disabled component gets removed again, even if the collisions aren't happening.
Testing
Steps to test:
Video of bugged behavior:
Screen.Recording.2025-11-15.at.04.00.00-1-1.mov
The pink area is a simple system that propels colliding bodies upward, and as you can see in the video it works even when they're not in contact. PR solves the issue completely.