Improves convex_decomposition and convex_hull methods#944
Open
FredMarquer wants to merge 2 commits intoavianphysics:mainfrom
Open
Improves convex_decomposition and convex_hull methods#944FredMarquer wants to merge 2 commits intoavianphysics:mainfrom
FredMarquer wants to merge 2 commits intoavianphysics:mainfrom
Conversation
added 2 commits
February 12, 2026 22:20
# Objective Don't take ownership of the vertices and indices in the `convex_decomposition` and `convex_hull` methods. ## Solution Replace the `Vec<_>` parameters with `&[_]`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Don't take ownership of the vertices and indices in the
convex_decompositionandconvex_hullmethods as it is not necessary.Solution
Replace the
Vec<_>parameters with&[_].Testing
I have tested the branch on my personal project (which only use convex_decomposition_with_config).