Fix Vec3A mismatch in obvhs sweep helpers#947
Open
muxyng wants to merge 1 commit intoavianphysics:mainfrom
Open
Fix Vec3A mismatch in obvhs sweep helpers#947muxyng wants to merge 1 commit intoavianphysics:mainfrom
muxyng wants to merge 1 commit intoavianphysics:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a glam
Vec3Amismatch inobvhs_extwhen dependency resolution pulls different glam minors.I convert the inputs into the AABB vector type before doing arithmetic, so we avoid cross-type ops.
Checked with
cargo check -p avian3dandcargo check -p avian2d.