Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing link target attribute #307

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

TeekshaHarish
Copy link
Contributor

🛠️ Fixes Issue

Fix for issue #306

➕ Changes Introduced

changed the target attribute of the links of social handles
I have tested the code after changes

@avinash201199
Copy link
Owner

can you explain about this pr ?

@TeekshaHarish
Copy link
Contributor Author

The links in the footer of the social media handles like LinkedIn, Github, Instagram were opening in the same tab as of the website, so it makes the simultaneous navigation of website and the social handle site side by side difficult, as to view to website the person has to use the browser back button which removes the progress(or what they were searching on that site) lost and if they want to go back to that site like LinkedIn they would have to start over their searches there,which is not a good user experience according to me.
Thus by making the links of social handles like LinkedIn and Insta open in another tab instead of the same one, it provides the user better experience and he/she can switch between your social page and website easily without having to use the back button.
To do so i have added the target attribute of the links of social handles

@avinash201199 avinash201199 merged commit 0fea6da into avinash201199:main Oct 21, 2023
@avinash201199
Copy link
Owner

Thank you for your contribution:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants