Skip to content

Improved performance using batch translation in content.js #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
githubRupsa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved performance using batch translation in content.js #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 27 additions & 30 deletions content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,37 +44,34 @@ chrome.runtime.onMessage.addListener((request, sender, sendResponse) => {

// Translate paragraph by paragraph
async function translateParagraphs() {
const paragraphs = document.querySelectorAll('p, h1, h2, h3, h4, h5, h6, li, span, div');
let translatedCount = 0;

for (let i = 0; i < paragraphs.length; i++) {
const element = paragraphs[i];
if (element.textContent.trim() &&
element.childNodes.length === 1 &&
element.childNodes[0].nodeType === Node.TEXT_NODE &&
!element.classList.contains('hinglish-translated')) {

const originalText = element.textContent;

try {
const response = await chrome.runtime.sendMessage({
action: "translateText",
text: originalText
});

if (response && response !== "Please configure your API key first") {
element.textContent = response;
element.classList.add('hinglish-translated');
translatedCount++;
}
} catch (error) {
console.error('Translation error:', error);
}
}
}

return translatedCount;
const paragraphs = Array.from(document.querySelectorAll('p, h1, h2, h3, h4, h5, h6, li, span, div'));
const textNodes= paragraphs.filter(el=>
el.textContent.trim() &&
el.childNodes.length===1 &&
el.childNodes[0].nodeType === Node.TEXT_NODE &&
!el.classList.contains('hinglish-translated')

);
const originalTexts = textNodes.map(el => el.textContent);
try {
const { translations, error } = await chrome.runtime.sendMessage({
action: "translateBatch",
texts: originalTexts
});

if (error) throw new Error(error);

textNodes.forEach((el, i) => {
el.textContent = translations[i];
el.classList.add('hinglish-translated');
});
} catch (error) {
console.error("Batch translation failed:", error);
}
}




// Translate all text nodes (more aggressive approach)
async function translateAllText() {
Expand Down