-
Notifications
You must be signed in to change notification settings - Fork 107
Upgrade to react 19 #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Upgrade to react 19 #425
Conversation
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
|
The lock file is generated using pnpm 7.30.0, not sure why it breaks builds. |
|
Hey @avkonst. Would you be able to take a look at this PR this week? |
|
Hi, thank you for contribution. I am not able to look at this week but will try on weekend or next week. Could you please investigate what changed in the rerender from 2 to 3? That will help a lot |
|
@avkonst do you need any help maybe? |
do not throw hookstate-109 in dev mode
Phylum OSS Supply Chain Risk Analysis - FAILEDThis repository analyzes the risk of new dependencies. An If you see this comment, one or more dependencies have failed Phylum's risk analysis. Package:
|
|
Hi @RomanHotsiy . Sorry for dropping the ball here, life carried over with changes and I am overloaded over the board now. If you can help that would be great. If you could investigate the remaining two tests failing, suggest a fix in PR and I will merge. If you would like to take more active role in the project. I am happy to share as well. |
I also upgraded the testing library as the @testing-library/react-hooks is deprecated.
Fixes #423
A few notable changes:
useMemotypings in react changed sodepsargument can't be undefined anymore (I updated in the code)@testing-library/reactdoesn't returnerrorbut throws instead