virt_vm: fix migration timeout limit #1083
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream qemu recently changed the migration max downtime from 3600 to 2000 (see qemu commit 87c9cc1c). This caused an error if test script calls save_to_file() defined in qemu_vm.py because MIGRATE_TIMEOUT is passed to self.monitor.migrate_set_downtime(). The error reads "Parameter 'downtime_limit' expects an integer in the range of 0 to 2000 seconds". This patch addresses the problem by changing the downtime limit to 2000. Signed-off-by: Wei Huang <[email protected]>
balamuruhans
requested changes
Jul 27, 2017
| @@ -502,7 +502,7 @@ class BaseVM(object): | |||
| LOGIN_TIMEOUT = 10 | |||
| LOGIN_WAIT_TIMEOUT = 240 | |||
| COPY_FILES_TIMEOUT = 600 | |||
| MIGRATE_TIMEOUT = 3600 | |||
| MIGRATE_TIMEOUT = 2000 | |||
There was a problem hiding this comment.
MIGRATE_TIMEOUT is used by API like def migrate() uses it for migration timeout.
so let us have MIGRATE_DOWNTIME = 2000 and set it for monitor.migrate_set_downtime(self.MIGRATE_DOWNTIME)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream qemu recently changed the migration max downtime from 3600 to
2000 (see qemu commit 87c9cc1c). This caused an error if test script
calls save_to_file() defined in qemu_vm.py because MIGRATE_TIMEOUT is
passed to self.monitor.migrate_set_downtime(). The error reads
"Parameter 'downtime_limit' expects an integer in the range of 0 to
2000 seconds".
This patch addresses the problem by changing the downtime limit to 2000.
Signed-off-by: Wei Huang [email protected]