virttest: Always disable io-reserve on root-port #1462
Conversation
it's recommended not to enable io-reserve on pcie-root-port to avoid out
of IO issues when too many devices are plugged there. Some details can
be found here:
https://bugzilla.redhat.com/show_bug.cgi?id=1518278
Signed-off-by: Lukáš Doktor <[email protected]>
| @@ -1337,6 +1337,10 @@ def sort_key(dev): | |||
| for pcic in params.objects("pci_controllers"): | |||
| dev = devices.pcic_by_params(pcic, params.object_params(pcic)) | |||
| pcics.append(dev) | |||
| # To avoid SeaBIOS out of IO issues always disable | |||
| # "io-reserve" on "pcie-root-port" | |||
There was a problem hiding this comment.
Does OVMF need same configuration too? @jingzhao84 Could you help confirm? Thanks.
There was a problem hiding this comment.
@vivianQizhu yes, the same configuration with OVMF
@ldoktor did you consider a device actually need to reserve IO when pass a device to the root port ?
There was a problem hiding this comment.
For now I did not. How about setting it only when io-reserve is not defined?
There was a problem hiding this comment.
(I mean I considered adding it as a configuration, but this seemed more-like default than configuration so I think it should be in code. But I can add a configuration param to be able to enable it. Would that work for you?)
|
@vivianQizhu should I rebase this, or are other changes required? |
|
@ldoktor I have talked to Q35 feature owner @jingzhao84 , she thought it is not proper to force all pcie-root-port to |
|
@ldoktor @vivianQizhu the io-reseve=0 is just a hint, the firmware should allocate
Thanks |
|
Sure, let's move the discussion to: https://bugzilla.redhat.com/show_bug.cgi?id=1518278 and when we reach a conclusion we could update our code... |
it's recommended not to enable io-reserve on pcie-root-port to avoid out
of IO issues when too many devices are plugged there. Some details can
be found here:
Signed-off-by: Lukáš Doktor [email protected]