Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared.cfg.guest-os: Add RHEL.8 variant config files #1942

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions shared/cfg/guest-os/Linux/RHEL/8.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
- 8:
variants:
- aarch64:
vm_arch_name = aarch64
- ppc64le:
vm_arch_name = ppc64le
- s390x:
vm_arch_name = s390x
- x86_64:
vm_arch_name = x86_64
os_variant = rhel8
unattended_install.url:
#Running from http server, RHEL requires more memory
mem = 2048
nic_hotplug:
modprobe_module =
block_hotplug:
modprobe_module =
no unattended_install..floppy_ks
unattended_install, check_block_size.4096_512, check_block_size.512_512, svirt_install:
cdrom_unattended = images/${os_variant}-${vm_arch_name}/ks.iso
syslog_server_proto = udp
unattended_install, svirt_install:
kernel = images/${os_variant}-${vm_arch_name}/vmlinuz
initrd = images/${os_variant}-${vm_arch_name}/initrd.img
# ARCH dependent things
aarch64:
grub_file = /boot/grub/grub.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For aarch64, no this file, but /boot/efi/EFI/redhat/grub.cfg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanan-fu are you sure? Is there any documentation about it? There is the same path for aarch64 in case of RHEL.7.devel

grub_file = /boot/grub/grub.conf

So this line needs correction as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i checked with a latest rhel8 host for arm:

[root@hp-moonshot-03-c07 ~]# uname -r
4.18.0-67.el8.aarch64
[root@hp-moonshot-03-c07 ~]# ls /boot/grub2/
grubenv
[root@hp-moonshot-03-c07 ~]# ls /boot/efi/EFI/redhat/grub.cfg 
/boot/efi/EFI/redhat/grub.cfg

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdkdd For aarch64 vm, result is same with above.
From this document: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8-beta/html-single/8.0_beta_release_notes/index#infrastructure_services_3
it use /etc/grub2.cfg, and it is a soft link:
aarch64:

ll /etc/grub2-efi.cfg 
lrwxrwxrwx. 1 root root 31 Oct 19 17:42 /etc/grub2-efi.cfg -> ../boot/efi/EFI/redhat/grub.cfg

x86:

ll /etc/grub2.cfg 
lrwxrwxrwx. 1 root root 22 Dec 19 13:02 /etc/grub2.cfg -> ../boot/grub2/grub.cfg

For RHEL.7.devel, i am not very sure what it used for since i never use it. What i know is RHEL-ALT, aarch64 use /boot/efi/EFI/redhat/grub.cfg too. @ldoktor do you know it ?

install_timeout = 7200
ppc64le:
no guest_s3, guest_s4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to double-check whether suspend/hibernate is supported in RHEL.8 (it was not in RHEL.7, which is the reason for those...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can suspend/hibernate VM according to https://www.linux-kvm.org/page/PowerManagement. I tested this, but I was not able to wake up VM afterwards (maybe to send some key is not enough - do not know). There is also possibility to suspend and resume VM using virsh. I tested this and for RHEL.8 x86_64 it works. I did not find any official documentation regarding (un)support of suspend/hibernate. So I am not sure about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The virsh suspend should be a different feature. Anyway see the email from David, it is not supported so please keep it here until someone asks it to enable this.

mem_chk_cmd = numactl --hardware | awk -F: '/size/ {print $2}'
netdev_peer_re = "(.*?): .*?\\\s(.*?):"
s390x:
grub_file = /boot/grub/grub.conf
install_timeout = 7200
kernel = images/${os_variant}-${vm_arch_name}/kernel.img
unattended_install, check_block_size.4096_512, check_block_size.512_512, svirt_install:
# Anaconda hardcodes headless installation of RHEL.7 on s390x
vga = none
inactivity_watcher = none
take_regular_screendumps = no
x86_64:
grub_file = /boot/grub2/grub.cfg
9 changes: 9 additions & 0 deletions shared/cfg/guest-os/Linux/RHEL/8/8.devel.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
- devel:
# Uses defaults set in 8.cfg
# Adding x.y versions should only require changing the kickstart
# and adding per-arch image shas.
image_name = images/${os_variant}devel-${vm_arch_name}
unattended_install.cdrom:
cdrom_cd1 = isos/linux/RHEL-8-devel-${vm_arch_name}.iso
unattended_install, check_block_size.4096_512, check_block_size.512_512, svirt_install:
unattended_file = unattended/RHEL-8-devel.ks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you add RHEL-8-devel.ks too ? or a separate commit/patch ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @yanan-fu,
we - SPICE-QE use custom kickstart file for RHEL-8.
I would create ks file for RHEL-8 here as well, but Appstream repo is needed to install @Workstation group. I do not know how to include it without explicitly specifying our internal path to the repo. Any hint?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point, I forgot about the kickstart file. Would you please add it with commented repo entry with a comment that one should add his own url? Besides, specifying url directly from kickstart does not work: https://bugzilla.redhat.com/show_bug.cgi?id=1649359

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdkdd AFAIK, currently, RHEL8 iso include both BaseOs and AppStream, no need to add AppStream repo extra if install from iso.
Also, you can refer this commit 81f9de5. We support to add extra repo in ks:

  1. Define kickstart_extra_repos in test.
  2. Add KVM_TEST_REPOS in ks.