Add a param to force use serial session in case of failure #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathnaga
force-pushed
the
serial_login_param
branch
from
9f986ff to
f472dc9
Compare
|
Sometimes we need to be ware of the network broken, so I suppose we better let users decide use serial or not(if they care about the network issue). |
|
@vivianQizhu True, bydefault the behaviour is same as previous, just introducing additional user param, to decide to override consciously in some situations, to do that, this patch would help in general for all tests without any changes.. |
|
@vivianQizhu Agree, this will be a useful workaround by not touching the old testcases. |
Currently, we do have a logic in wait_for_login to return serial session incase of failure if provided by the user through function param, this patch extends that functionality by adding a param which can be used to set, So serial session is returned in case of failure, as most of the testcases using wait_for_login with default params and we do not need to modify the testcases, this can be useful during certain env issues if we want to force use serial logins for the same test. Signed-off-by: Satheesh Rajendran <[email protected]>
sathnaga
force-pushed
the
serial_login_param
branch
from
f472dc9 to
fe4e1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we do have a logic in wait_for_login to
return serial session incase of failure if provided
by the user through function param, this patch extends
that functionality by adding a param which can be use set,
so that serial session is returned in case of failure,
this will be helpful as we most of the testcases using
wait_for_login with default params and we do not need
to modify the testcases, this can be useful during certain
env issues if we want to force use serial logins for the same test.
Signed-off-by: Satheesh Rajendran [email protected]