RFC: virttest.virt_vm: Attempt to log useful data on login failure #1969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hackish way of attempting to log useful data on login failure. Signed-off-by: Lukáš Doktor <[email protected]>
ldoktor
force-pushed
the
PoC-log-journal
branch
from
f53f829 to
ba784b5
Compare
sathnaga
reviewed
Feb 25, 2019
| @@ -1190,6 +1190,19 @@ def print_guest_network_info(): | |||
| return self.wait_for_serial_login(timeout, internal_timeout, | |||
| False, username, password) | |||
|
|
|||
| # Attempt to log useful data | |||
| try: | |||
There was a problem hiding this comment.
makes sense, can be handled as part of post-process instead?
There was a problem hiding this comment.
Well, handling it in post might be to late as the test might shut the machine down before the test finishes (this works even for intermittent VMs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hackish way of attempting to log useful data on login failure. This is not intended for merging but rather a discussion whether something like this should be created.