Skip to content

Commit

Permalink
selftests: drop job-api test variant that may exceed sqlite3's own li…
Browse files Browse the repository at this point in the history
…mits

The sqlite3 module (and actually, even the non-python binary with the
same name), have "interesting" limitations when it comes to the
database path.

When the test that creates the journal file, and checks for it, runs
as part of an RPM build, the extra directories (/buildir/...) exceed
the path size limit.

While it would be possible to check if the "logdir" path, plus the
name of the journal database path, would eventually exceed the sqlite3
limits, this logic would be exclusive for one test variant.

IMO it does not justify adding such logic to keep a test that has
considerably low value.

Signed-off-by: Cleber Rosa <[email protected]>
  • Loading branch information
clebergnu committed Nov 27, 2024
1 parent d668281 commit d6e4c64
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions selftests/check.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"job-api-check-category-directory-exists": 1,
"job-api-check-directory-exists": 2,
"job-api-check-file-content": 9,
"job-api-check-file-exists": 12,
"job-api-check-file-exists": 11,
"job-api-check-output-file": 4,
"job-api-check-tmp-directory-exists": 1,
"nrunner-interface": 70,
Expand Down Expand Up @@ -492,13 +492,6 @@ def get_ref(method_short_name):
"file": "result.xml",
"assert": False,
},
# this test needs a huge improvement
{
"namespace": "run.journal.enabled",
"value": True,
"file": ".journal.sqlite",
"assert": True,
},
],
}

Expand Down

0 comments on commit d6e4c64

Please sign in to comment.