avocado-instrumented/python-unittest resolvers: improve fail message #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message given by the avocado-instrumented and python-unittest resolvers, resolvers that share a lot of code and require Python files, can be made clearer. One of the earliest checks performed is about the file *name* and its *suffix*, and not necessarily about an actual file (that exists). Even though the concepts are pretty close, let's make it clear that these resolvers are rejecting the references given based on the ".py" suffix not existing in the file name, and not necessarily, at that time, rejecting it based on an actual existing file. Signed-off-by: Cleber Rosa <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6065 +/- ##
==========================================
- Coverage 54.47% 54.44% -0.03%
==========================================
Files 202 202
Lines 21874 21882 +8
==========================================
- Hits 11915 11914 -1
- Misses 9959 9968 +9 ☔ View full report in Codecov by Sentry. |
richtja
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message given by the avocado-instrumented and python-unittest resolvers, resolvers that share a lot of code and require Python files, can be made clearer.
One of the earliest checks performed is about the file name and its suffix, and not necessarily about an actual file (that exists). Even though the concepts are pretty close, let's make it clear that these resolvers are rejecting the references given based on the ".py" suffix not existing in the file name, and not necessarily, at that time, rejecting it based on an actual existing file.